Incidencia #44790

gtk2: repodlgs.c "dangling pointer to 'tech_name' may be used"

Abrir Fecha: 2022-06-11 10:56 Última actualización: 2022-06-13 01:06

Informador:
Propietario:
Tipo:
Estado:
Cerrado
Componente:
Prioridad:
5 - Medium
Gravedad:
5 - Medium
Resolución:
Fixed
Fichero:
3

Details

Building S3_0 with gcc-12 and -O3 failed on gtk2-client repodlgs.c to several "dangling pointer to 'tech_name' may be used" -warnings.

I've not yet checked if other gtk-clients / other branches are affected.

Given that gcc-12 is stable already, I think we should postpone 3.0.2 release for this (especially if other gtk-clients are affected)

Ticket History (3/8 Histories)

2022-06-11 10:56 Updated by: cazfi
  • New Ticket "gtk2: repodlgs.c "dangling pointer to 'tech_name' may be used"" created
2022-06-11 11:22 Updated by: cazfi
Comentario

All gtk-clients are affected. Don't really know how the compiler gets warning like that out of it, but I noticed that the use of gtk_tree_model_get() in science_report_combo_get_active() (and callers) doesn't really comply with gtk documentation, but results in memory leak. Fixing that made also the compiler warning to go away.

2022-06-11 11:35 Updated by: cazfi
  • Propietario Update from (Ninguno) to cazfi
  • Resolución Update from Ninguno to Accepted
  • Componente Update from (Ninguno) to Gtk3.22-client
Comentario

S3_0 patch attached - may push this earlier than to other branches, to unblock 3.0.2 release.

2022-06-11 12:29 Updated by: cazfi
Comentario

Patches for the remaining branches attached. Will push S3_0 patch to S2_6 too.

2022-06-13 01:06 Updated by: cazfi
  • Estado Update from Open to Cerrado
  • Resolución Update from Accepted to Fixed

Editar

Please login to add comment to this ticket » Entrar