ucrt64: get_lanserver_announcement(): readfs used uninitialized

• Informador: cazfi
• Propietario: cazfi
• Tipo: Bugs
• Estado: Cerrado
• Componente: Windows Installers
• Hito: 3.1.0 (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 1

Details Responder

I did first test to build using ucrt64 toolchain of msys2.

In file included from C:/freeciv/msys2/prod/msys2-freeciv-win64-220611/mingw64/include/winsock2.h:56,

from ../../../../utility/fc_prehdrs.h:30,
from ../../../../server/sernet.c:18:

C:/freeciv/msys2/prod/msys2-freeciv-win64-220611/mingw64/include/psdk_inc/_fd_types.h: In function 'get_lanserver_announcement':
C:/freeciv/msys2/prod/msys2-freeciv-win64-220611/mingw64/include/psdk_inc/_fd_types.h:77:48: error: 'readfs' may be used uninitialized [-Werror=maybe-uninitialized!]

77 | if (((fd_set *)(set))->fd_array[__i!] == (fd)) { \

|

../../../../server/sernet.c:1463:10: note: 'readfs' declared here

1463 | fd_set readfs, exceptfs;

| ^~

Ticket History (3/5 Histories)

2022-06-14 12:55 Updated by: cazfi

• New Ticket "ucrt64: get_lanserver_announcement(): readfs used uninitialized" created

2022-06-14 13:27 Updated by: cazfi

Comentario Responder

Reply To cazfi

In file included from C:/freeciv/msys2/prod/msys2-freeciv-win64-220611/mingw64/include/winsock2.h:56

Likely the problem is in that "/mingw64/". And likely that somehow comes from the fact that our msys2 Makefile (and the win_arch.sh it uses) understands only two different systems; win32 and win64.

2022-06-20 04:00 Updated by: cazfi

• File 0043-Msys2-Makefile-Add-ucrt64-support.patch (File ID: 9549) is attached

2022-06-20 04:02 Updated by: cazfi

• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Ninguno to Accepted
• Hito Update from (Ninguno) to 3.1.0 (cerrado)
• Componente Update from General to Windows Installers

Comentario Responder

Reply To cazfi

Likely the problem is in that "/mingw64/". And likely that somehow comes from the fact that our msys2 Makefile (and the win_arch.sh it uses) understands only two different systems; win32 and win64.

That was the problem, and that's what the attached patch fixes (gets rid of win_arch.sh completely, and uses MSYSTEM instead)

2022-06-25 01:04 Updated by: cazfi

• Estado Update from Open to Cerrado
• Resolución Update from Accepted to Fixed