sdl2: SDL_GetColorKey() assumed to success

• Informador: cazfi
• Propietario: cazfi
• Tipo: Bugs
• Estado: Cerrado
• Componente: SDL2-client
• Hito: 3.0.3 (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 2

Details

sdl2-client get_smaller_surface_rect() calls SDL_GetColorKey(), assumes it success, and goes on using the key. The problem is, we don't set the key for most surfaces, and often that call actually fails.

Ticket History (3/8 Histories)

2022-06-21 18:54 Updated by: cazfi

• New Ticket "sdl2: SDL_GetColorKey() assumed to succes" created

2022-06-21 20:45 Updated by: cazfi

Comentario

This affects, e.g., #44891

2022-06-21 20:47 Updated by: cazfi

• Hito Update from (Ninguno) to 3.0.3 (cerrado)

2022-06-22 02:04 Updated by: cazfi

• File 0059-sdl2-Search-icon-borders-by-alpha-when-no-colorkey-a.patch (File ID: 9580) is attached

2022-06-22 02:04 Updated by: cazfi

• File 0026-sdl2-Search-icon-borders-by-alpha-when-no-colorkey-a.patch (File ID: 9581) is attached

2022-06-22 02:05 Updated by: cazfi

• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Ninguno to Accepted

Comentario

Going to push S3_0 patch to S2_6 too

2022-06-22 02:08 Updated by: cazfi

• Summary Updated

2022-06-27 11:03 Updated by: cazfi

• Estado Update from Open to Cerrado
• Resolución Update from Accepted to Fixed