Prefer signal.h over sys/signal.h

• Informador: cazfi
• Propietario: cazfi
• Tipo: Patches
• Estado: Cerrado
• Componente: General
• Hito: 3.0.6 (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 2

Details

netintf.c includes sys/signal.h instead of signal.h, though that is far from recommendations. I believe that reason is ancient - some *nix where freeciv was developed in the 90's had some issue with signal.h (not yet standardised to that over sys/signal.h). Likely there's no reason to keep it that way 202x.

Ticket History (3/7 Histories)

2022-07-04 02:46 Updated by: cazfi

• New Ticket "Prefer signal.h over sys/signal.h" created

2022-07-04 02:50 Updated by: cazfi

• File 0061-Prefer-signal.h-over-sys-signal.h.patch (File ID: 9700) is attached

2022-07-04 02:50 Updated by: cazfi

• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Ninguno to Accepted

2022-07-15 00:47 Updated by: cazfi

• Estado Update from Open to Cerrado
• Resolución Update from Accepted to Fixed

2023-01-17 10:23 Updated by: cazfi

• File 0006-Prefer-signal.h-over-sys-signal.h.patch (File ID: 11383) is attached

2023-01-17 10:24 Updated by: cazfi

• Estado Update from Cerrado to Open
• Resolución Update from Fixed to Accepted
• Hito Update from 3.1.0 (cerrado) to 3.0.6 (cerrado)

Comentario

This issue affects void linux / musl build also in older branches - let's backport the fix. Old patch applies to S3_0. For S2_6 a new patch has been attached.

2023-01-19 04:08 Updated by: cazfi

• Estado Update from Open to Cerrado
• Resolución Update from Accepted to Fixed