Adjust city name in network protocol

• Informador: cazfi
• Propietario: (Ninguno)
• Tipo: Patches
• Estado: Open
• Componente: General
• Hito: S3_2 npf
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Ninguno
• Fichero: Ninguno

Details Responder

Likely the network protocol could be made better concerning city names (in city_info etc), esp. after #45786 and #45844

Ticket History (3/3 Histories)

2022-10-13 02:50 Updated by: cazfi

• New Ticket "Adjust city name in network protocol" created

2022-10-27 01:54 Updated by: cazfi

• Hito Update from S3_1 npf (cerrado) to S3_2 npf

Comentario Responder

Network protocol is already smart enough to send city name as NULL-terminated string, and not a fixed size array. So nothing to do for that.

Second thing considered was that city name could be moved to a packet of its own to avoid too big PACKET_CITY_INFO. For that part, there's a couple of much worse offenders -> will open a new tickets about those.
City name as part of PACKET_CITY_INFO isn't problem in S3_1. Let's recheck the situation before 3.2, especially if MAX_LEN_CITYNAME gets increased -> retargeting to S3_2-npf

2022-11-21 10:50 Updated by: cazfi

Comentario Responder

Reply To cazfi

Second thing considered was that city name could be moved to a packet of its own to avoid too big PACKET_CITY_INFO. For that part, there's a couple of much worse offenders -> will open a new tickets about those.

-> #46079, #46080

(Edited, 2022-11-21 11:08 Updated by: cazfi)