sdl2: 'count' in popup_diplomatic_objects() unsigned

• Informador: cazfi
• Propietario: cazfi
• Tipo: Patches
• Estado: Cerrado
• Componente: SDL2-client
• Hito: 3.0.5 (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 2

Details

To human eye, 'count' in popup_diplomatic_objects() is clearly always positive (initialized as 0, and ever only increased by 1). Clang analyzer seems to fail realize that, as it gives warning about division by zero that could happen only if 'count < 0' (count must be smaller than the divider). Formally declaring 'count' unsigned makes the warning to go away.

Ticket History (3/5 Histories)

2022-10-27 10:27 Updated by: cazfi

• New Ticket "sdl2: 'count' in popup_diplomatic_objects() unsigned" created

2022-10-30 04:07 Updated by: cazfi

• File 0039-sdl2-Make-some-popup_diplomatic_objects-vars-unsigne.patch (File ID: 10720) is attached

2022-10-30 04:07 Updated by: cazfi

• File 0030-sdl2-Make-some-popup_diplomatic_objects-vars-unsigne.patch (File ID: 10721) is attached

2022-10-30 04:08 Updated by: cazfi

• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Ninguno to Accepted

Comentario

Attached patches touch a couple of other variables too (size, width and height, related ones)

2022-11-06 00:56 Updated by: cazfi

• Estado Update from Open to Cerrado
• Resolución Update from Accepted to Fixed