Incidencia #46278

city_rally_point_receive() 'pcity' should not be nonnull

Abrir Fecha: 2022-12-16 01:02 Última actualización: 2022-12-16 02:44

Informador:
Propietario:
Tipo:
Estado:
Cerrado
Componente:
Prioridad:
9 - Highest
Gravedad:
5 - Medium
Resolución:
Fixed
Fichero:
1

Details

CI build mac-meson complains about the fact that city_rally_point_receive() makes a tautological check against NULL pcity while the parameter is defined nonnull.

I think we have to support NULL pcity there, even though I've not seen any compiler to give an error about NULL passed now that it has been nonnull.

Ticket History (3/4 Histories)

2022-12-16 01:02 Updated by: cazfi
  • New Ticket "city_rally_point_receive() 'pcity' should not be nonnull" created
2022-12-16 01:09 Updated by: cazfi
  • Propietario Update from (Ninguno) to cazfi
  • Resolución Update from Ninguno to Accepted
  • Prioridad Update from 5 - Medium to 9 - Highest
Comentario

As a (macos) build breakage, should be treated as an emergency fix. Will test the attached patch and then push immediately, if seems fine.

2022-12-16 02:44 Updated by: cazfi
  • Estado Update from Open to Cerrado
  • Resolución Update from Accepted to Fixed

Editar

Please login to add comment to this ticket » Entrar