bool player_has_color() returning NULL

• Informador: cazfi
• Propietario: cazfi
• Tipo: Bugs
• Estado: Cerrado
• Componente: Client common
• Hito: 3.0.6 (cerrado)
• Prioridad: 5 - Medium
• Gravedad: 5 - Medium
• Resolución: Fixed
• Fichero: 4

Details

player_has_color() has "fc_assert_ret_val(pplayer != NULL, NULL);" while it's supposed to return boolean.

Found by attempting c2x standards build with gcc-13.

Ticket History (3/7 Histories)

2022-12-18 23:45 Updated by: cazfi

• New Ticket "bool player_has_color() returning NULL" created

2022-12-19 00:31 Updated by: cazfi

• File 0042-Return-FALSE-instead-of-NULL-from-player_has_color.patch (File ID: 11155) is attached

2022-12-19 00:31 Updated by: cazfi

• File 0030-Return-FALSE-instead-of-NULL-from-player_has_color.patch (File ID: 11156) is attached

2022-12-19 00:31 Updated by: cazfi

• File 0020-Return-FALSE-instead-of-NULL-from-player_has_color.patch (File ID: 11157) is attached

2022-12-19 00:32 Updated by: cazfi

• File 0004-Return-FALSE-instead-of-NULL-from-player_has_color.patch (File ID: 11158) is attached

2022-12-19 00:32 Updated by: cazfi

• Propietario Update from (Ninguno) to cazfi
• Resolución Update from Ninguno to Accepted
• Hito Update from (Ninguno) to 3.0.6 (cerrado)

Comentario

Also S2_6 version.

2022-12-27 14:59 Updated by: cazfi

• Estado Update from Open to Cerrado
• Resolución Update from Accepted to Fixed