Reply To cazfi
Split from #47697, which already has a patch ( https://osdn.net/ticket/download.php?group_id=12505&tid=47697&file_id=12014 ) Client / help system changes to show pages about counters.
Reply To lachu
Reply To cazfi
Split from #47697, which already has a patch ( https://osdn.net/ticket/download.php?group_id=12505&tid=47697&file_id=12014 ) Client / help system changes to show pages about counters.
0003-OSDN-TICKET-47697-S-awomir-Lach-slawek-lach.art.pl.patch(3KB) Changes - version from previous ticket (server side to support description)
I put bad description. Patch contains client-side, but requires also to apply server side/network changes.
../src/client/helpdata.c: In function ‘boot_help_texts’:
../src/client/helpdata.c:1112:19: error: declaration of ‘i’ shadows a previous local [-Werror=shadow]
1112 | int i;
| ^
../src/client/helpdata.c:731:7: note: shadowed declaration is here
731 | int i;
| ^
- The patch seems to touch client-common code only. Doesn't it require gui-specific parts too? Each gui to show that new help page?
Reply To cazfi
{{{ ../src/client/helpdata.c: In function ‘boot_help_texts’: ../src/client/helpdata.c:1112:19: error: declaration of ‘i’ shadows a previous local -Werror=shadow 1112 | int i; | ../src/client/helpdata.c:731:7: note: shadowed declaration is here 731 | int i; | }}} --- - The patch seems to touch client-common code only. Doesn't it require gui-specific parts too? Each gui to show that new help page?
As far as I can tell, it do not require gui-specific code. We had helpdata.txt, where new section is defined and common-gui code to generate this new section. I could add new gui-specific code to GTK+-4 client to shown more info (like checkpoint) in table format, but I think this patch fulfilled simplicity requirement.
Reply To cazfi
{{{ ../src/client/helpdata.c: In function ‘boot_help_texts’: ../src/client/helpdata.c:1112:19: error: declaration of ‘i’ shadows a previous local -Werror=shadow 1112 | int i; | ../src/client/helpdata.c:731:7: note: shadowed declaration is here 731 | int i; | }}} --- - The patch seems to touch client-common code only. Doesn't it require gui-specific parts too? Each gui to show that new help page?
Look above message. Thanks.
Reply To cazfi
Reply To lachu
Reply To cazfi
- The patch seems to touch client-common code only. Doesn't it require gui-specific parts too? Each gui to show that new help page?
Look above message. Thanks.
And the variable shadowing warning from the compiler?
2023-05-21 22:14 Updated by: lachu
Sorry you must wait so long. I have less free time by now, but I will try to gather some time to develop freeciv in future weeks.
Qt-client does not compile:
../src/client/gui-qt/helpdlg.cpp: In member function ‘void help_widget::set_topic(const help_item*)’:
../src/client/gui-qt/helpdlg.cpp:808:10: error: enumeration value ‘HELP_COUNTER’ not handled in switch [-Werror=switch]
808 | switch (topic->type) {
Better summary of counters needed:
+text = "SAAAASDSWDWWDWD"
Any progress with this?
Content distribution network do not work, but I put newest patch. I hope it will match changes prepared in previous patches.
Content distribution network do not work, but I put newest patch. I hope it will match changes prepared in previous patches.
I mean I cannot download previous patches to check, what changes it trying to introduce.
The patch does not apply. Likely broken by "Current Musicset" help page.
Split from #47697, which already has a patch ( https://osdn.net/ticket/download.php?group_id=12505&tid=47697&file_id=12014 )
Client / help system changes to show pages about counters.