Incidencia #48214

ASSERT_UNUSED_ACTRES_CASES / ASSERT_UNUSED_ACTION_CASES

Abrir Fecha: 2023-06-11 13:08 Última actualización: 2023-06-17 11:10

Informador:
Propietario:
Tipo:
Estado:
Cerrado
Componente:
Hito:
Prioridad:
5 - Medium
Gravedad:
5 - Medium
Resolución:
Fixed
Fichero:
2

Details

Split from the patch I'm working on for #48135

Add macros ASSERT_UNUSED_ACTRES_CASES and ASSERT_UNUSED_ACTION_CASES for supporting unused entries within enumerations of actres and actions. We have many 'switch - case' -constructs that require all those values to be present as cases. Just include these new macros to such switch, and then on we can control such unused values by modifying those macros only, i.e., only in one place instead of large number of switches.

Ticket History (3/7 Histories)

2023-06-11 13:08 Updated by: cazfi
  • New Ticket "ASSERT_UNUSED_ACTRES_CASES / ASSERT_UNUSED_ACTION_CASES" created
2023-06-11 13:16 Updated by: cazfi
  • Propietario Update from (Ninguno) to cazfi
  • Resolución Update from Ninguno to Accepted
Comentario

The attached patch likely applies no matter whether #48146 has been applied first or not, but it does not handle the switch that #48146 removes from actions.c. So this patch will need updating (completing) if #48146 gets rejected.

2023-06-14 12:23 Updated by: cazfi
  • Resolución Update from Accepted to Ninguno
Comentario

Needed in adv_gov_action_immunity_want() too.

2023-06-14 13:13 Updated by: cazfi
  • Resolución Update from Ninguno to Accepted
Comentario

Reply To cazfi

Needed in adv_gov_action_immunity_want() too.

New patch version attached. Includes fix for this.

2023-06-17 11:10 Updated by: cazfi
  • Estado Update from Open to Cerrado
  • Resolución Update from Accepted to Fixed

Editar

Please login to add comment to this ticket » Entrar