[Groonga-commit] groonga/gcs [master] bq: throw exception for invalid field name character

Back to archive index

null+****@clear***** null+****@clear*****
2012年 8月 6日 (月) 13:38:42 JST


Kouhei Sutou	2012-08-06 13:38:42 +0900 (Mon, 06 Aug 2012)

  New Revision: 7a2137194c70d72c6e246ece5501af42d79745ff
  https://github.com/groonga/gcs/commit/7a2137194c70d72c6e246ece5501af42d79745ff

  Log:
    bq: throw exception for invalid field name character

  Modified files:
    lib/bq-translator.js
    test/bq-translator.test.js

  Modified: lib/bq-translator.js (+2 -2)
===================================================================
--- lib/bq-translator.js    2012-08-06 13:37:15 +0900 (82109ac)
+++ lib/bq-translator.js    2012-08-06 13:38:42 +0900 (e5f0752)
@@ -132,8 +132,8 @@ BooleanQueryTranslator.prototype = {
                                    "field:<" + field + ">");
         }
       } else {
-        // TODO: report error: invalid field character
-        return "";
+        this.throwTranslateError("invalid field character: " +
+                                 "<" + character + ">");
       }
     }
 

  Modified: test/bq-translator.test.js (+4 -0)
===================================================================
--- test/bq-translator.test.js    2012-08-06 13:37:15 +0900 (1aa3396)
+++ test/bq-translator.test.js    2012-08-06 13:38:42 +0900 (d790f83)
@@ -159,6 +159,10 @@ suite('BoolanQueryTranslator', function() {
                  "(field f1)",
                  "(field f1|)|",
                  "field value is missing: field:<f1>");
+  testGroupError("field: invalid field name",
+                 "(field fIeld 'value')",
+                 "(field f|I|eld 'value')",
+                 "invalid field character: <I>");
 
   testExpression("value only: stirng: and: space",
                  "'keyword1 keyword2' 'other keyword'",
-------------- next part --------------
HTML$B$NE:IU%U%!%$%k$rJ]4I$7$^$7$?(B...
Descargar 



Groonga-commit メーリングリストの案内
Back to archive index