[Groonga-commit] long-long-float/droonga-engine at 61a5f49 [install-script] Change shell

Back to archive index

YUKI Hiroshi yuki****@clear*****
Wed Sep 3 10:59:04 JST 2014


https://github.com/droonga/droonga-engine/pull/20#commitcomment-7634291
こちらで林さんからも指摘が付いていますが、「何故明示的にbashを指定しなく
てはならなかったのか?」という理由をコミットメッセージに含めた方が良かっ
たのではないかと思います。



long-long-float wrote:
> Author
>     long-long-float <niinikazuki �� yahoo.co.jp>
> Date
>     2014-09-02 20:23:36 +0900 (Tue, 02 Sep 2014)
> New Revision
>     61a5f49fe1456eddb0ee8dfede170529e1dede19
>     <https://github.com/long-long-float/droonga-engine/commit/61a5f49fe1456eddb0ee8dfede170529e1dede19>
> Message
> 
>     Change shell
> 
> Modified files
> 
>       * script/droonga-engine
>         <https://github.com/long-long-float/droonga-engine/commit/61a5f49fe1456eddb0ee8dfede170529e1dede19#diff-0>
> 
>   Modified: script/droonga-engine (+1 -1)
> ===================================================================
> 
> ... <https://github.com/long-long-float/droonga-engine/commit/61a5f49fe1456eddb0ee8dfede170529e1dede19#L0L0>
> 1 <https://github.com/long-long-float/droonga-engine/commit/61a5f49fe1456eddb0ee8dfede170529e1dede19#L0L1>
>  
> 2 <https://github.com/long-long-float/droonga-engine/commit/61a5f49fe1456eddb0ee8dfede170529e1dede19#L0L2>
> 3 <https://github.com/long-long-float/droonga-engine/commit/61a5f49fe1456eddb0ee8dfede170529e1dede19#L0L3>
> 4 <https://github.com/long-long-float/droonga-engine/commit/61a5f49fe1456eddb0ee8dfede170529e1dede19#L0L4>
> 
> 	
> 
> ... <https://github.com/long-long-float/droonga-engine/commit/61a5f49fe1456eddb0ee8dfede170529e1dede19#L0R0>
>  
> 1 <https://github.com/long-long-float/droonga-engine/commit/61a5f49fe1456eddb0ee8dfede170529e1dede19#L0R1>
> 2 <https://github.com/long-long-float/droonga-engine/commit/61a5f49fe1456eddb0ee8dfede170529e1dede19#L0R2>
> 3 <https://github.com/long-long-float/droonga-engine/commit/61a5f49fe1456eddb0ee8dfede170529e1dede19#L0R3>
> 4 <https://github.com/long-long-float/droonga-engine/commit/61a5f49fe1456eddb0ee8dfede170529e1dede19#L0R4>
> 
> 	
> 
> @@ -1,4 +1,4 @@
> -#! /bin/sh
> +#! /bin/bash
>  ### BEGIN INIT INFO
>  # Provides:          droonga-engine
>  # Required-Start:    $remote_fs $syslog
> 
> 
> 
> _______________________________________________
> Groonga-commit mailing list
> Groonga-commit �� lists.sourceforge.jp
> http://lists.sourceforge.jp/mailman/listinfo/groonga-commit
> 

-- 
結城 洋志 <YUKI Hiroshi>
E-mail: yuki �� clear-code.com

株式会社クリアコード
〒170-0005 東京都豊島区南大塚3-29-9
           中野ビル3階
TEL : 03-5927-9440
FAX : 03-5927-9441
WWW : http://www.clear-code.com/




More information about the Groonga-commit mailing list
Back to archive index