[Groonga-commit] groonga/groonga-query-log at 4c2d69f [master] groonga-query-log-run-regression-test: don't output query log by default

Back to archive index

Kouhei Sutou null+****@clear*****
Thu Jun 4 09:52:29 JST 2015


Kouhei Sutou	2015-06-04 09:52:29 +0900 (Thu, 04 Jun 2015)

  New Revision: 4c2d69f40eda0629e5ed188fba3d441957154a9f
  https://github.com/groonga/groonga-query-log/commit/4c2d69f40eda0629e5ed188fba3d441957154a9f

  Message:
    groonga-query-log-run-regression-test: don't output query log by default
    
    Query log becomes very large when regression test target query log is
    very large.
    
    ATTENTION: It's not tested yet. It should be tested before we release a
    new version!

  Modified files:
    lib/groonga/query-log/command/run-regression-test.rb

  Modified: lib/groonga/query-log/command/run-regression-test.rb (+18 -8)
===================================================================
--- lib/groonga/query-log/command/run-regression-test.rb    2015-05-26 11:22:55 +0900 (c2ab1d6)
+++ lib/groonga/query-log/command/run-regression-test.rb    2015-06-04 09:52:29 +0900 (f0e2a32)
@@ -42,6 +42,7 @@ module Groonga
           @load_data = true
           @run_queries = true
           @skip_finished_queries = false
+          @output_query_log = false
         end
 
         def run(command_line)
@@ -119,6 +120,10 @@ module Groonga
                     "Don't run finished query logs.") do
             @skip_finished_queries = true
           end
+          parser.on("--output-query-log",
+                    "Output query log in verified target Groonga servers") do
+            @output_query_log = true
+          end
 
           parser
         end
@@ -136,6 +141,7 @@ module Groonga
             :run_queries           => @run_queries,
             :recreate_database     => @recreate_database,
             :skip_finished_queries => @skip_finished_queries,
+            :output_query_log      => @output_query_log,
           }
           directory_options.merge(options)
         end
@@ -175,14 +181,18 @@ module Groonga
             ensure_database
             return unless @options[:run_queries]
 
-            @pid = spawn(@groonga,
-                         "--bind-address", @host,
-                         "--port", @port.to_s,
-                         "--log-path", log_path.to_s,
-                         "--query-log-path", query_log_path.to_s,
-                         "--protocol", "http",
-                         "-s",
-                         @database_path.to_s)
+            arguments = [
+              "--bind-address", @host,
+              "--port", @port.to_s,
+              "--protocol", "http",
+              "--log-path", log_path.to_s,
+            ]
+            if @options[:output_query_log]
+              arguments.concat(["--query-log-path", query_log_path.to_s])
+            end
+            arguments << "-s"
+            arguments << @database_path.to_s
+            @pid = spawn(@groonga, *arguments)
 
             n_retries = 10
             begin
-------------- next part --------------
HTML����������������������������...
Descargar 



More information about the Groonga-commit mailing list
Back to archive index