[Groonga-commit] groonga/groonga-admin at dfed889 [master] Remove needless (obsolete) operations to resolve columns

Back to archive index

YUKI Hiroshi null+****@clear*****
Fri Sep 23 12:28:35 JST 2016


YUKI Hiroshi	2016-09-23 12:28:35 +0900 (Fri, 23 Sep 2016)

  New Revision: dfed88991af5f44cd20d89afca67c0711c0d8201
  https://github.com/groonga/groonga-admin/commit/dfed88991af5f44cd20d89afca67c0711c0d8201

  Merged 2dd9aa7: Merge pull request #11 from groonga/features/migrate-column_list-to-schema

  Message:
    Remove needless (obsolete) operations to resolve columns

  Modified files:
    app/scripts/services/schema-loader.js

  Modified: app/scripts/services/schema-loader.js (+0 -21)
===================================================================
--- app/scripts/services/schema-loader.js    2016-09-23 12:27:59 +0900 (c8a55d1)
+++ app/scripts/services/schema-loader.js    2016-09-23 12:28:35 +0900 (64e459d)
@@ -91,10 +91,6 @@ angular.module('groongaAdminApp')
         }
       }
 
-      function isReferenceType(schema, typeName) {
-        return typeName in schema.tables;
-      }
-
       function buildTable(rawTable) {
         var table = {};
         table.id           = 0; // XXX it exists in a table_list response but missing in a schema response.
@@ -144,22 +140,6 @@ angular.module('groongaAdminApp')
         return tables;
       }
 
-      function resolveColumn(schema, column) {
-        column.valueType = {
-          name: column.range,
-          isTextType: isTextType(column.range),
-          isReferenceType: isReferenceType(schema, column.range)
-        };
-      }
-
-      function resolveColumns(schema) {
-        angular.forEach(schema.tables, function(table) {
-          angular.forEach(table.columns, function(column) {
-            resolveColumn(schema, column);
-          });
-        });
-      }
-
       function resolveIndex(schema, column) {
         var table = schema.tables[column.range];
         column.sources.forEach(function(source) {
@@ -280,7 +260,6 @@ angular.module('groongaAdminApp')
 
             return $q.all(fetchColumnsTasks)
               .then(function() {
-                resolveColumns(schema);
                 resolveIndexes(schema);
                 fetched = true;
                 fetching = false;
-------------- next part --------------
HTML����������������������������...
Descargar 



More information about the Groonga-commit mailing list
Back to archive index