[Groonga-commit] groonga/groonga-admin at 5d873ff [master] Don't run same loop multiple times

Back to archive index

YUKI Hiroshi null+****@clear*****
Fri Sep 23 13:14:06 JST 2016


YUKI Hiroshi	2016-09-23 13:14:06 +0900 (Fri, 23 Sep 2016)

  New Revision: 5d873ffa9d02d33cccd5f7b651b76391f9053cc1
  https://github.com/groonga/groonga-admin/commit/5d873ffa9d02d33cccd5f7b651b76391f9053cc1

  Merged ec78f51: Merge pull request #13 from groonga/features/build-schema-from-schema-result

  Message:
    Don't run same loop multiple times

  Modified files:
    app/scripts/services/schema-loader.js

  Modified: app/scripts/services/schema-loader.js (+2 -4)
===================================================================
--- app/scripts/services/schema-loader.js    2016-09-23 13:13:49 +0900 (8e4aa83)
+++ app/scripts/services/schema-loader.js    2016-09-23 13:14:06 +0900 (ca86448)
@@ -80,6 +80,8 @@ angular.module('groongaAdminApp')
         table.range  = table.valueType; // for backward compatibility
         table.domain = table.keyType && table.keyType.name; // for backward compatibility
 
+        table.columns = buildColumns(rawTable);
+
         return table;
       }
 
@@ -207,10 +209,6 @@ angular.module('groongaAdminApp')
 
             schema.tables = buildTables(rawTables);
 
-            angular.forEach(schema.tables, function(table) {
-              table.columns = buildColumns(rawTables[table.name]);
-            });
-
             resolveIndexes(schema);
             fetched = true;
             fetching = false;
-------------- next part --------------
HTML����������������������������...
Descargar 



More information about the Groonga-commit mailing list
Back to archive index