[Groonga-commit] groonga/groonga-query-log at f3ebd1f [master] run-regression-test: use more meaningful name

Back to archive index
Yasuhiro Horimoto null+****@clear*****
Tue Nov 6 17:43:55 JST 2018


Yasuhiro Horimoto	2018-11-06 17:43:55 +0900 (Tue, 06 Nov 2018)

  Revision: f3ebd1f0512cd230197e5ad5176173b5926bb4ca
  https://github.com/groonga/groonga-query-log/commit/f3ebd1f0512cd230197e5ad5176173b5926bb4ca

  Merged a90ef28: Merge pull request #35 from komainu8/improve_stop_on_failure

  Message:
    run-regression-test: use more meaningful name

  Modified files:
    lib/groonga-query-log/server-verifier.rb

  Modified: lib/groonga-query-log/server-verifier.rb (+5 -5)
===================================================================
--- lib/groonga-query-log/server-verifier.rb    2018-11-06 17:01:07 +0900 (885156d)
+++ lib/groonga-query-log/server-verifier.rb    2018-11-06 17:43:55 +0900 (4e2fad9)
@@ -33,13 +33,13 @@ module GroongaQueryLog
 
     def verify(input, &callback)
       @same = true
-      @client_error = false
+      @client_error_is_occurred = false
       producer = run_producer(input, &callback)
       reporter = run_reporter
       producer.join
       @different_results.push(nil)
       reporter.join
-      @same and !@client_error
+      @same and !@client_error_is_occurred
     end
 
     private
@@ -51,7 +51,7 @@ module GroongaQueryLog
         n_commands = 0
         callback_per_n_commands = 100
         parser.parse(input) do |statistic|
-          break if (!@same or @client_error) and****@optio*****_on_failure?
+          break if (!@same or @client_error_is_occurred) and****@optio*****_on_failure?
 
           command = statistic.command
           next if command.nil?
@@ -100,7 +100,7 @@ module GroongaQueryLog
               log_client_error($!) do
                 $stderr.puts(original_source)
               end
-              @client_error = true
+              @client_error_is_occurred = true
               return false
             end
             if****@optio*****_cache?
@@ -111,7 +111,7 @@ module GroongaQueryLog
                 log_client_error($!) do
                   $stderr.puts("status after #{original_source}")
                 end
-                @client_error = true
+                @client_error_is_occurred = true
                 return false
               end
             end
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.osdn.me/mailman/archives/groonga-commit/attachments/20181106/f1729ac3/attachment-0001.html>


More information about the Groonga-commit mailing list
Back to archive index