ishii****@nttda*****
ishii****@nttda*****
2015年 8月 20日 (木) 11:13:18 JST
Hi, I attached new patch. I fixed the part of previous one. Changes from the last time: ・Delete unnecessary "CREATE USER" (We use "CREATE USER" only when we create normal user.) ・Change the sample text for textporter. Regards, > -----Original Message----- > From: ludia****@lists***** > [mailto:ludia****@lists*****] On Behalf Of > ishii****@nttda***** > Sent: Tuesday, August 18, 2015 11:04 AM > To: ludia****@lists***** > Subject: Re: [Ludiafuncs-hackers] Add regression tests > > Thank you for the reply. > I attached new patch. > > 1)000_ludia_funcs_regress.patch > - make installcheck > - normal test for ludia_funcs > 2)001_ludia_funcs_regress_textporter.patch > - make installcheck-textporter > - test for ludia_funcs with textporter > - User has to install textporter, and compile ludia_funcs with > textporter option before testing. > ex) make USE_PGXS=1 SENNA_CFG=*** TEXTPORTER=*** > 3)002_ludia_funcs_regress_debug_option.patch > - make installcheck-debug-option > - test for ludia_funcs's internal operation > - User has to compile ludia_funcs with debug option before testing. > ex) make USE_PGXS=1 SENNA_CFG=*** CFLAGS=-DPGS2_DEBUG > > > > 1) make installcheck > > > -ludia_funcs has only regression test for pgs2snippet1(). > > > This patch adds test for pgs2norm(). > > > 2) make installcheck-textporter > > > -This is test for textporter. > > > User who want to use ludia_funcs together with textporter will > > conduct this test. > > > User has to install textporter before testing. > > > > The both #1 and #2 regression test seems not to work fine in my > > environment, which doesn't have postgres user. > > I fixed the problem. > > > I have applied this patch without ERROR, but I think it would be > > better to separate these regression test into different patches. > > I agree with you. > > > ludia_funcs.sql and debug-option.sql have extra new lines at very > > bottom of itself. > > > > Why did you add DROP EXTENSION ludia_funcs; into sql file? > > > > Could you explain about the reason why we need to create new database > > for textporter regression test in textporter.sql? > > I deleted extra lines, DROP EXTENSION, CREATE DATABASE. > As you said, these were unnecessary process. > > Regards, > > -- > Ayumi Ishii > NTT DATA CORPORATION -------------- next part -------------- $B%F%-%9%H7A<00J30$NE:IU%U%!%$%k$rJ]4I$7$^$7$?(B... $B%U%!%$%kL>(B: ludia_funcs_regress_patch.zip $B7?(B: application/x-zip-compressed $B%5%$%:(B: 23675 $B%P%$%H(B $B ＠ bL@(B: ludia_funcs_regress_patch.zipDescargar
Fork