Incidencia #42105

Show a (cultivate|plant|transform)_time of 0

Abrir Fecha: 2021-04-29 03:58 Última actualización: 2021-05-31 20:01

Informador:
Propietario:
Tipo:
Estado:
Cerrado
Componente:
Prioridad:
5 - Medium
Gravedad:
5 - Medium
Resolución:
Accepted
Fichero:
3

Details

A cultivate_time, plant_time or transform_time of 0 isn't illegal. Show those values in the in game help.

Ticket History (3/13 Histories)

2021-04-29 03:58 Updated by: kvilhaugsvik
  • New Ticket "Show a (cultivate|plant|transform)_time of 0" created
2021-04-29 04:24 Updated by: kvilhaugsvik
  • Resolución Update from Ninguno to Accepted
  • Hito Update from (Ninguno) to 2.6.5 (cerrado)
Comentario

3.0 patch applies to 2.6 too.

2021-04-29 07:31 Updated by: cazfi
Comentario

But it means that activity is disabled.

2021-04-29 07:51 Updated by: cazfi
Comentario

Reply To cazfi

But it means that activity is disabled.

..or at least what rulesets document for transform_time.

I have to check what my intention was when I reworked that stuff as part of introducing cultivate/plant. Probably meant to have ruleset loading time guard that when an activity is enabled, to remove need to check both when ever activity's legality is checked.

2021-04-29 16:39 Updated by: kvilhaugsvik
Comentario

Reply To cazfi

I have to check what my intention was when I reworked that stuff as part of introducing cultivate/plant.

A transform_time of 0 i legal in 2.6 too.

2021-04-29 17:17 Updated by: cazfi
Comentario

Reply To kvilhaugsvik

Reply To cazfi

I have to check what my intention was when I reworked that stuff as part of introducing cultivate/plant.

A transform_time of 0 i legal in 2.6 too.

But is documented not to be.

2021-04-30 14:23 Updated by: cazfi
Comentario

-> #42120

With my current plans this ticket (the patches) still remains relevant, even if the intent changes a bit. After a couple of dependency patches get implemented, we can remove those checks for non-zero _time as redundant.

2021-05-01 09:23 Updated by: cazfi
Comentario
2021-05-14 21:59 Updated by: cazfi
Comentario

Reply To cazfi

With my current plans this ticket (the patches) still remains relevant, even if the intent changes a bit. After a couple of dependency patches get implemented, we can remove those checks for non-zero _time as redundant.

That probably require changing only the commit message.

2021-05-31 20:01 Updated by: kvilhaugsvik

Editar

Please login to add comment to this ticket » Entrar