Incidencia #48837

Player removal not removing city border claims

Abrir Fecha: 2023-10-13 03:51 Última actualización: 2023-10-25 00:38

Informador:
Propietario:
Tipo:
Estado:
Cerrado
Componente:
Prioridad:
5 - Medium
Gravedad:
5 - Medium
Resolución:
Fixed
Fichero:
9

Details

server_remove_player() calls player_clear() in common/ code, and that removes cities by game_remove_city() only, while proper server side city removal would include remove_city() call. This likely has other effects, but I noticed this while debugging why there's a city border claim from already removed player.

Ticket History (3/15 Histories)

2023-10-13 03:51 Updated by: cazfi
  • New Ticket "Player removal not removing city border claims" created
2023-10-13 04:13 Updated by: cazfi
  • Propietario Update from (Ninguno) to cazfi
  • Resolución Update from Ninguno to Accepted
Comentario

Patches for all branches, including S2_6, attached.

2023-10-15 03:46 Updated by: cazfi
  • Resolución Update from Accepted to Ninguno
Comentario

Currrent patch seems to cause some crashes itself.

2023-10-17 06:05 Updated by: cazfi
  • Resolución Update from Ninguno to Accepted
Comentario

Reply To cazfi

Currrent patch seems to cause some crashes itself.

Fixed. Was about accessing nonexistent visions.

2023-10-18 12:23 Updated by: cazfi
Comentario

Reply To cazfi

Reply To cazfi

Currrent patch seems to cause some crashes itself.

Fixed. Was about accessing nonexistent visions.

New versions attached, with one more nonexistent vision issue resolved.

2023-10-25 00:38 Updated by: cazfi
  • Estado Update from Open to Cerrado
  • Resolución Update from Accepted to Fixed

Editar

Please login to add comment to this ticket » Entrar