Commit: 8503d6e1e564cb5ac61bc6e3f16c0b384c76661e - binutils_os216 (git)

GNU Binutils with patches for OS216

Commit MetaInfo

• Revisión: 8503d6e1e564cb5ac61bc6e3f16c0b384c76661e (tree)
• Tiempo: 2015-01-07 00:07:12
• Autor: Joel Brobecker <brobecker@adac...>
• Commiter: Joel Brobecker

Log Message

gdb/python: exception trying to create empty array

The following python command fails:

(gdb) python print gdb.lookup_type('char').array(1, 0)
Traceback (most recent call last):

File "<string>", line 1, in <module>

ValueError: Array length must not be negative
Error while executing Python code.

The above is trying to create an empty array, which is fairly command
in Ada.

gdb/ChangeLog:

• • • • python/py-type.c (typy_array_1): Do not raise negative-length
        exception if N2 is equal to N1 - 1.
        

gdb/testsuite/ChangeLog:

• • • • gdb.python/py-type.exp: Add a couple test about empty
        array creation, and negative-length array creation.
        

Cambiar Resumen

• modified: gdb/ChangeLog
• modified: gdb/python/py-type.c
• modified: gdb/testsuite/ChangeLog
• modified: gdb/testsuite/gdb.python/py-type.exp

Diferencia incremental

--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
[phone]  Joel Brobecker  <[e-mail]>
+
+	* python/py-type.c (typy_array_1): Do not raise negative-length
+	exception if N2 is equal to N1 - 1.
+
 2015-01-03  Doug Evans  <[e-mail]>
 
 	* c-exp.y: Whitespace cleanup.

--- a/gdb/python/py-type.c
+++ b/gdb/python/py-type.c
@@ -528,7 +528,7 @@ typy_array_1 (PyObject *self, PyObject *args, int is_vector)
       n1 = 0;
     }
 
-  if (n2 < n1)
+  if (n2 < n1 - 1)
     {
       PyErr_SetString (PyExc_ValueError,
 		       _("Array length must not be negative"));

--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
[phone]  Joel Brobecker  <[e-mail]>
+
+	* gdb.python/py-type.exp: Add a couple test about empty
+	array creation, and negative-length array creation.
+
 2015-01-02  Doug Evans  <[e-mail]>
 
 	* gdb.cp/nsalias.exp: Fix output of external/declaration flags.

--- a/gdb/testsuite/gdb.python/py-type.exp
+++ b/gdb/testsuite/gdb.python/py-type.exp
@@ -247,6 +247,12 @@ restart_gdb "${binfile}"
 # Skip all tests if Python scripting is not enabled.
 if { [skip_python_tests] } { continue }
 
+gdb_test "python print gdb.lookup_type('char').array(1, 0)" \
+    "char \\\[0\\\]"
+
+gdb_test "python print gdb.lookup_type('char').array(1, -1)" \
+    "Array length must not be negative.*"
+
 with_test_prefix "lang_c" {
     runto_bp "break to inspect struct and array."
     test_fields "c"