Commit: c714b42695bbe7ff5e22aae2f91f9071b3ecf601 - binutils_os216 (git)

GNU Binutils with patches for OS216

Commit MetaInfo

• Revisión: c714b42695bbe7ff5e22aae2f91f9071b3ecf601 (tree)
• Tiempo: 2013-04-20 00:35:58
• Autor: Pedro Alves <palves@redh...>
• Commiter: Pedro Alves

Log Message

-Wpointer-sign: ada-lang.c, ada-tasks.c.

We're reading strings using the target memory access routines, which
work with raw bytes, so we need a couple casts.

gdb/
2013-04-19 Pedro Alves <[e-mail]>

* ada-lang.c (print_it_exception): Add cast to gdb_byte *.
* ada-tasks.c (read_fat_string_value): Likewise.

Cambiar Resumen

• modified: gdb/ChangeLog
• modified: gdb/ada-lang.c
• modified: gdb/ada-tasks.c

Diferencia incremental

--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2013-04-19  Pedro Alves  <[e-mail]>
 
+	* ada-lang.c (print_it_exception): Add cast to gdb_byte *.
+	* ada-tasks.c (read_fat_string_value): Likewise.
+
[phone]  Pedro Alves  <[e-mail]>
+
 	* dwarf2-frame.c (execute_cfa_program): Make 'bytes_read' local
 	unsigned.  Pass 'tmp' to safe_read_uleb128 instead of the signed
 	'offset', and adjust.

--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -11532,7 +11532,8 @@ print_it_exception (enum exception_catchpoint_kind ex, bpstat bs)
 
 	  if (addr != 0)
 	    {
-	      read_memory (addr, exception_name, sizeof (exception_name) - 1);
+	      read_memory (addr, (gdb_byte *) exception_name,
+			   sizeof (exception_name) - 1);
 	      exception_name [sizeof (exception_name) - 1] = '\0';
 	    }
 	  else

--- a/gdb/ada-tasks.c
+++ b/gdb/ada-tasks.c
@@ -433,7 +433,7 @@ read_fat_string_value (char *dest, struct value *val, int max_len)
 
   /* Extract LEN characters from the fat string.  */
   array_val = value_ind (value_field (val, array_fieldno));
-  read_memory (value_address (array_val), dest, len);
+  read_memory (value_address (array_val), (gdb_byte *) dest, len);
 
   /* Add the NUL character to close the string.  */
   dest[len] = '\0';