Commit: e0139aa5f27ebef0bd92a182beca659e169560ef - binutils_os216 (git)

GNU Binutils with patches for OS216

Commit MetaInfo

• Revisión: e0139aa5f27ebef0bd92a182beca659e169560ef (tree)
• Tiempo: 2016-07-06 15:31:20
• Autor: Markus Metzger <markus.t.metzger@inte...>
• Commiter: Markus Metzger

Log Message

btrace: check if we're replaying when setting the replay position to the end

When setting the replay position to the end there is nothing to do if we are
not replaying. Check that and return immediately.

This avoids printing the current location if we're already at the end.

Signed-off-by: Markus Metzger <[e-mail]>

gdb/
* record-btrace.c (record_btrace_set_replay): Check if replaying.

testsuite/
* gdb.btrace/record_goto.exp: Test "record goto end" twice.

Change-Id: I4878892408bab293261bbea40d6af28440ff3ec5

Cambiar Resumen

• modified: gdb/record-btrace.c
• modified: gdb/testsuite/gdb.btrace/record_goto.exp

Diferencia incremental

--- a/gdb/record-btrace.c
+++ b/gdb/record-btrace.c
@@ -2704,7 +2704,12 @@ record_btrace_set_replay (struct thread_info *tp,
   btinfo = &tp->btrace;
 
   if (it == NULL || it->function == NULL)
-    record_btrace_stop_replaying (tp);
+    {
+      if (!btrace_is_replaying (tp))
+	return;
+
+      record_btrace_stop_replaying (tp);
+    }
   else
     {
       if (btinfo->replay == NULL)

--- a/gdb/testsuite/gdb.btrace/record_goto.exp
+++ b/gdb/testsuite/gdb.btrace/record_goto.exp
@@ -160,6 +160,9 @@ gdb_test "record instruction-history -" [multi_line \
 # check that we can go to the end of the trace
 gdb_test "record goto end" ".*main \\(\\) at record_goto.c:50.*"
 
+# check that we don't repeat the current location if we go to the end again
+gdb_test_no_output "record goto end" "goto end again"
+
 # check that we're filling up the context correctly
 gdb_test "record function-call-history /ci" [multi_line \
   "14\t      fun2\tinst 35,36" \