Commit: b9f31c6bdc9fb20c88b8f6cf4a39f627fa228a83 - packages-apps-Browser (git)

packages/apps/Browser

Commit MetaInfo

• Revisión: b9f31c6bdc9fb20c88b8f6cf4a39f627fa228a83 (tree)
• Tiempo: 2011-05-28 05:43:23
• Autor: John Reck <jreck@goog...>
• Commiter: Android (Google) Code Review

Log Message

Merge "DO NOT MERGE Fix vanishing title/url in window picker" into gingerbread

Cambiar Resumen

• modified: src/com/android/browser/Tab.java

Diferencia incremental

--- a/src/com/android/browser/Tab.java
+++ b/src/com/android/browser/Tab.java
@@ -43,6 +43,7 @@ import android.os.Message;
 import android.os.SystemClock;
 import android.provider.Browser;
 import android.speech.RecognizerResultsIntent;
+import android.text.TextUtils;
 import android.util.Log;
 import android.view.KeyEvent;
 import android.view.LayoutInflater;
@@ -1862,8 +1863,8 @@ class Tab {
     // Populate the picker data using the given history item and the current top
     // WebView.
     private void populatePickerData(WebHistoryItem item) {
-        mPickerData = new PickerData();
-        if (item != null) {
+        if (item != null && !TextUtils.isEmpty(item.getUrl())) {
+            mPickerData = new PickerData();
             mPickerData.mUrl = item.getUrl();
             mPickerData.mTitle = item.getTitle();
             mPickerData.mFavicon = item.getFavicon();
@@ -1950,7 +1951,6 @@ class Tab {
         // Restore the internal state even if the WebView fails to restore.
         // This will maintain the app id, original url and close-on-exit values.
         mSavedState = null;
-        mPickerData = null;
         mCloseOnExit = b.getBoolean(CLOSEONEXIT);
         mAppId = b.getString(APPID);
         mOriginalUrl = b.getString(ORIGINALURL);