Commit: 434f2bce706b209a0f6d8c45a0be13891abe18e9 - frameworks-base (git)

frameworks/base

Commit MetaInfo

• Revisión: 434f2bce706b209a0f6d8c45a0be13891abe18e9 (tree)
• Tiempo: 2019-12-09 00:21:19
• Autor: Seigo Nonaka <nona@goog...>
• Commiter: Vasyl Gello

Log Message

Do not compute outside given range in TextLine

This is second attempt of I646851973b3816bf9ba32dfe26748c0345a5a081
which breaks various layout test on application.
The empty string must be also handled by the TextLine since it
retrieves the default line height from the empty string.

Bug: 140632678
Test: StaticLayoutTest
Test: Manually done
Change-Id: I7089ed9b711dddd7de2b27c9c2fa0fb4cb53a735

Cambiar Resumen

• modified: core/java/android/text/TextLine.java

Diferencia incremental

--- a/core/java/android/text/TextLine.java
+++ b/core/java/android/text/TextLine.java
@@ -208,6 +208,7 @@ class TextLine {
         int lastRunIndex = runs.length - 2;
         for (int i = 0; i < runs.length; i += 2) {
             int runStart = runs[i];
+            if (runStart > mLen) break;
             int runLimit = runStart + (runs[i+1] & Layout.RUN_LENGTH_MASK);
             if (runLimit > mLen) {
                 runLimit = mLen;
@@ -285,6 +286,7 @@ class TextLine {
         int[] runs = mDirections.mDirections;
         for (int i = 0; i < runs.length; i += 2) {
             int runStart = runs[i];
+            if (runStart > mLen) break;
             int runLimit = runStart + (runs[i+1] & Layout.RUN_LENGTH_MASK);
             if (runLimit > mLen) {
                 runLimit = mLen;
@@ -374,6 +376,7 @@ class TextLine {
         int[] runs = mDirections.mDirections;
         for (int i = 0; i < runs.length; i += 2) {
             int runStart = runs[i];
+            if (runStart > mLen) break;
             int runLimit = runStart + (runs[i + 1] & Layout.RUN_LENGTH_MASK);
             if (runLimit > mLen) {
                 runLimit = mLen;