Commit: 27a8c0511f436a5ed6ed735d992547b9cea65a3d - opentween (git)

開発に使用するリポジトリ

Commit MetaInfo

• Revisión: 27a8c0511f436a5ed6ed735d992547b9cea65a3d (tree)
• Tiempo: 2013-01-13 03:33:33
• Autor: Kimura Youichi <kim.upsilon@bucy...>
• Commiter: Kimura Youichi

Log Message

PictureBox.Visible の変更に何故か時間が掛かる問題の回避

Cambiar Resumen

• modified: OpenTween.Tests/TweetThumbnailTest.cs
• modified: OpenTween/TweetThumbnail.cs

Diferencia incremental

--- a/OpenTween.Tests/TweetThumbnailTest.cs
+++ b/OpenTween.Tests/TweetThumbnailTest.cs
@@ -84,7 +84,6 @@ namespace OpenTween
                 Assert.That(picbox.SizeMode, Is.EqualTo(PictureBoxSizeMode.Zoom));
                 Assert.That(picbox.WaitOnLoad, Is.False);
                 Assert.That(picbox.Dock, Is.EqualTo(DockStyle.Fill));
-                Assert.That(picbox.Visible, Is.False);
 
                 picbox.Dispose();
             }
@@ -124,6 +123,8 @@ namespace OpenTween
                     num++;
                 }
 
+                Assert.That(thumbbox.Controls, Is.EquivalentTo(new Control[]{ thumbbox.scrollBar }.Concat(thumbbox.pictureBox)));
+
                 Assert.That(thumbbox.scrollBar.Minimum, Is.EqualTo(0));
                 Assert.That(thumbbox.scrollBar.Maximum, Is.EqualTo(count));
             }

--- a/OpenTween/TweetThumbnail.cs
+++ b/OpenTween/TweetThumbnail.cs
@@ -89,7 +89,6 @@ namespace OpenTween
                             cancelToken.ThrowIfCancellationRequested();
                         }
 
-                        this.pictureBox[0].Visible = true;
                         this.scrollBar.Maximum = thumbnails.Count - 1;
 
                         if (thumbnails.Count > 1)
@@ -147,6 +146,7 @@ namespace OpenTween
             for (int i = 0; i < count; i++)
             {
                 var picbox = CreatePictureBox("pictureBox" + i);
+                picbox.Visible = (i == 0);
                 picbox.DoubleClick += this.pictureBox_DoubleClick;
 
                 this.Controls.Add(picbox);
@@ -164,7 +164,6 @@ namespace OpenTween
                 SizeMode = PictureBoxSizeMode.Zoom,
                 WaitOnLoad = false,
                 Dock = DockStyle.Fill,
-                Visible = false,
             };
         }
 
@@ -190,6 +189,7 @@ namespace OpenTween
 
         private void scrollBar_ValueChanged(object sender, EventArgs e)
         {
+            this.SuspendLayout();
             for (var i = 0; i < this.pictureBox.Count; i++)
             {
                 var picbox = this.pictureBox[i];
@@ -199,6 +199,18 @@ namespace OpenTween
                 else
                     picbox.Visible = false;
             }
+            this.ResumeLayout(false);
+        }
+
+        private void ShowPictureBox(int index)
+        {
+            foreach (Control control in this.Controls)
+            {
+                if (control is PictureBox)
+                    this.Controls.Remove(control);
+            }
+
+            this.Controls.Add(this.pictureBox[index]);
         }
 
         private void pictureBox_DoubleClick(object sender, EventArgs e)