Commit: 124e4cfaa42bb5a14eec33ea47d3502b5f46eb33 - qemu (git)

Commit MetaInfo

• Revisión: 124e4cfaa42bb5a14eec33ea47d3502b5f46eb33 (tree)
• Tiempo: 2019-07-23 18:31:07
• Autor: Philippe Mathieu-Daudé <philmd@redh...>
• Commiter: Philippe Mathieu-Daudé

Log Message

hw/block/pflash_cfi02: Rewrite a fall through comment

GCC9 is confused by this comment when building with CFLAG
-Wimplicit-fallthrough=2:

hw/block/pflash_cfi02.c: In function ‘pflash_write’:
hw/block/pflash_cfi02.c:574:16: error: this statement may fall through [-Werror=implicit-fallthrough=]

574 | if (boff == 0x55 && cmd == 0x98) {

|

hw/block/pflash_cfi02.c:581:9: note: here

581 | default:

|

cc1: all warnings being treated as errors

Rewrite the comment using 'fall through' which is recognized by
GCC and static analyzers.

Reported-by: Stefan Weil <[e-mail]>
Reviewed-by: Peter Maydell <[e-mail]>
Message-Id: <[e-mail]>
Signed-off-by: Philippe Mathieu-Daudé <[e-mail]>

Cambiar Resumen

• modified: hw/block/pflash_cfi02.c

Diferencia incremental

--- a/hw/block/pflash_cfi02.c
+++ b/hw/block/pflash_cfi02.c
@@ -577,7 +577,7 @@ static void pflash_write(void *opaque, hwaddr offset, uint64_t value,
                 pfl->cmd = 0x98;
                 return;
             }
-            /* No break here */
+            /* fall through */
         default:
             DPRINTF("%s: invalid write for command %02x\n",
                     __func__, pfl->cmd);