Commit: dbdaaff43adc49f1debd935b1fd58e2b47ba7676 - qemu (git)

Commit MetaInfo

• Revisión: dbdaaff43adc49f1debd935b1fd58e2b47ba7676 (tree)
• Tiempo: 2017-07-18 06:13:17
• Autor: Richard Henderson <rth@twid...>
• Commiter: Richard Henderson

Log Message

target/s390x: Fix risbg handling

The rotation is to the left, but extract shifts to the right.
The computation of the extract parameters needs adjusting.

For the entry condition, simplify

64 - rot + len <= 64
-rot + len <= 0
len <= rot

Reviewed-by: Aurelien Jarno <[e-mail]>
Reported-by: David Hildenbrand <[e-mail]>
Suggested-by: Aurelien Jarno <[e-mail]>
Signed-off-by: Richard Henderson <[e-mail]>

Cambiar Resumen

• modified: target/s390x/translate.c

Diferencia incremental

--- a/target/s390x/translate.c
+++ b/target/s390x/translate.c
@@ -3479,8 +3479,8 @@ static ExitStatus op_risbg(DisasContext *s, DisasOps *o)
     }
 
     /* In some cases we can implement this with extract.  */
-    if (imask == 0 && pos == 0 && len > 0 && rot + len <= 64) {
-        tcg_gen_extract_i64(o->out, o->in2, rot, len);
+    if (imask == 0 && pos == 0 && len > 0 && len <= rot) {
+        tcg_gen_extract_i64(o->out, o->in2, 64 - rot, len);
         return NO_EXIT;
     }