packages-apps-Settings

Fork

Merge "Update NotificationChannelSettings Preferences in place to prevent re-layout." into rvc-qpr-dev

Update NotificationChannelSettings Preferences in place to prevent re-layout.

(cherry picked from commit b409b640451cfc58fb529659b80cd872ed717095)

Fixes: 110093185
Test: ChannelListPreferenceControllerTest
Change-Id: If6acf305c44085e502a3304ea57e409ce049b40f
Merged-In: If6acf305c44085e502a3304ea57e409ce049b40f

Snap for 6900534 from fe66e87832d35ccb50105fe8fe7bba40fb82f173 to rvc-d2-release

Change-Id: I361fc197a14743e9e4f96566625e4edfa4a2572b

Reduce the flickering of injected items when package is changed am: e4b2b77452

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12771880

Change-Id: Ia334ab14dd3aa48c0d48ad6adcfd50ecfcb3400a

Hide 'View plan' button in data usage settings

There are currently no callers of the setSubscriptionPlan() API that
have a MDP app set up. Remove the button when SubscriptionPlans are
defined, since it does nothing and causes confusion for users.

Test: manually verify button does not exist when a plan is defined
Test: make RunSettingsRoboTests
Bug: 169806315
Change-Id: Ieda020bfa692e9465d6297e50cf338deff91a8a9

Reduce the flickering of injected items when package is changed

Root cause:
Settings listens to four package-related broadcasts in order to refresh
injected items because UI data may change. However, when the system is
updating apps on the first boot, it triggers a burst of broadcasts. For
each broadcast Settings will reload and then redraw all injected items,
which leads to the flickering.

Solution:
1. When Settings recieves a broadcast, check if there are already two
reloading tasks to avoid redundant updates.
2. In the reloading task, check if any injected item is changed, added,
or removed to notify categories changed.
3. Only refresh the UI when any of the changed items belongs to the
current page.

Bug: 166785977
Bug: 168309941
Test: manual, robotest
Change-Id: I77745b60f84510554bff1870a5bb7a8013eab528
Merged-In: I77745b60f84510554bff1870a5bb7a8013eab528
(cherry picked from commit 20df25e6b91fac0c10ce358210fbd37d7bdb754a)

Snap for 6887864 from ab41be5607fb2f8617f1d7c26ceb58dca12d374e to rvc-d2-release

Change-Id: Ie5dce473d5db33d8620dcb117ade8597b95b11cb

Merge "Hide tethering option when in a guest account" into rvc-qpr-dev

Snap for 6885047 from 7ea96cf6dbf6b3b75fe139a6a5b62a4c641b2cb7 to rvc-d2-release

Change-Id: Id1864eaf589dd88af9f84d55f4728afd893d1c69

Import translations. DO NOT MERGE ANYWHERE

Auto-generated-cl: translation import
Change-Id: I8bcf35d1b5eae3e56f485fa78ade8eea9ecb2deb

Snap for 6870886 from ce61ea1506c0b133da399755ce159405539b4ac7 to rvc-d2-release

Change-Id: I8d0c374a613c7b3255187acc2ebe8bdc4e5c7e10

Hide tethering option when in a guest account

- Before this CL, users can share their mobile data through enabling
tethering in the USB menu when in a guest account.
It will cause main users to spend their money unexpectedly.

This CL will hide the tethering option on the USB menu when in the
guest account.
- Add test cases.

Bug: 166125765
Test: 1. make -j42 RunSettingsRoboTests. 2. Switch to a guest account
to verify whether the tethering option is hiding.

Change-Id: I7523b3f3c3a1372bb128a58a6a7fac973d27cfbe
Merged-In: I7523b3f3c3a1372bb128a58a6a7fac973d27cfbe
(cherry picked from commit bde627b263baf3de10e096868235edde8e740eab)

Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-qpr-dev

Import translations. DO NOT MERGE ANYWHERE

Auto-generated-cl: translation import
Change-Id: I8b5b9411c949934d99bea34b0292d8e5de512413

Import translations. DO NOT MERGE ANYWHERE

Auto-generated-cl: translation import
Change-Id: Ic754186b5e7ee18485a2d441b10965d768072e24

Fix issue where "learn more" link on 5G NR settings doesn't work.

Issue is due to the fact the footer text is a spannable string which
although different from the original text loaded when the preference
was constructed, is the same in terms of object equality.
Clearing the preference title before assigning the footer text fixes this.

Fixes: 162011372
Test: Manual test; open settings and verify link is clickable now.
Merged-In: I5d22c665b0d6fb842bc54dc55a2eb3045e0092a2
Change-Id: I5d22c665b0d6fb842bc54dc55a2eb3045e0092a2
(cherry picked from commit 97d8711d847109722a2c1b26b81d3f61b15210ac)
Exempt-From-Owner-Approval: Straight cherry-pick.

Snap for 6863807 from faf7a2ad78a5cc769a6c687608df6ea449c7b4fa to rvc-d2-release

Change-Id: Id7a375c6330837dd45a13a7a3df912574c4c00fd

Merge "[adbwifi] wireless debugging qstile long-press to WirelessDebuggingFragment." into rvc-qpr-dev

Merge "Fix adb qr scanner text in dark mode." into rvc-qpr-dev

Fix adb qr scanner text in dark mode.

The text color is not right when in dark mode, which makes the text
invisible.

Bug: 168845829

Test: In dark/light mode, scan adb QR code and verify text is visible.
Exempt-From-Owner-Approval: Already approved in ag/12640175
Change-Id: I6d8e16fd2d848d09b49673db041c97d667fea6a9

Merge "Disable entry point of output switcher" into rvc-qpr-dev

Merge "Fix output switcher will display previous media session" into rvc-qpr-dev

Merge "[DO NOT MERGE] Fix the blank space on contextual card loading timeout" into rvc-qpr-dev

Disable entry point of output switcher

It adds a minimum value if it shows only one available
cast device in the output switcher. Because users can only
change the volume slider or stop control in the output switcher.
It's too hidden to have the user stop cast in the UI.

- This CL will disable the entry point of the output switcher
if there is only one available cast device in the list.
- Update test cases.

Bug: 163095048
Test: make -j42 RunSettingsRoboTests
Change-Id: I8906878e1ba769d6940041f17d83b5de6b2a32c0
Merged-In: I8906878e1ba769d6940041f17d83b5de6b2a32c0
(cherry picked from commit b6840ced0d735ce09dfea6a357bfab0a736b5873)

Import translations. DO NOT MERGE ANYWHERE

Auto-generated-cl: translation import
Change-Id: I14b1b7cb5aac3ce15594e0fe470b447e0adf72d6

[adbwifi] wireless debugging qstile long-press to WirelessDebuggingFragment.

Previously, long-pressing any developer options quick settings tiles
redirects to the application info page for Settings app. The manifest
change makes the long-press by default, go into the developer options
page.

Also, there's a check if the long-press came from the wireless debugging
tile so it can launch the WirelessDebuggingFragment.

Bug: 153275926

Test: Enable the wireless debugging qstile in developer options.
Then long-press the wireless debugging tile, which should direct you to
the WirelessDebuggingFragment. Also, enable any other qstile and
long-press them. It should direct you to the developer options page
instead of the application info page.

Change-Id: Id495e5c978005c21d0f33b949d7c410100bf3cf5

Merge "Guard against flickering of dynamic injection items" into rvc-qpr-dev

Guard against flickering of dynamic injection items

The summary of injected items may flicker when the data is change from
URI.

Root cause:
If an external app injects an entry to Settings with a dynamic summary,
Settings will observe the summary change via the provideed URI. However,
sometimes when Settings observes the data change and then refreshes the
UI, the data doesn't really change and settings still gets the same
summary. If it happens in a short period, the summary will seem
flickering.

Solution:
Check if the data really changes before refresh UI. Guard both title and
summary.

Fixes: 168309941
Fixes: 166785977
Test: robotest
Change-Id: I137fc317dcfd8919195c10fa8cf7d2559fe1029d

Fix output switcher will display previous media session

Before this CL, the same request code will cause intent to
be cached. It will cause the output switcher to display the
previous media session.

This CL uses the package name as an unique request code to
fix this issue.

Bug: 169077753
Test: make -j42 RunSettingsRoboTests
Change-Id: Iebfc7904609e243d5bf0222307bae98a952a3331
Merged-In: Iebfc7904609e243d5bf0222307bae98a952a3331
(cherry picked from commit c3fe8d87d6c4da8404da4df8a0b2432427ae6de4)

Update battery saver preference key

The updated preference key made slice auto conversion mechanism fail,
so when this slice is requested by external apps, the UI won't be shown
properly. So we need to revert the key to the original one.

Bug: 131897855
Test: manual test
1. Open Settings app -> Settings search -> search battery saver
2. Observe battery saver result item has a toggle

Change-Id: Ifb5b0a6786d60d1e67567272610cc3cb078f11a4
Merged-In: Ifb5b0a6786d60d1e67567272610cc3cb078f11a4