Incidencia #44372

effect_list_sanity_cb() uses log_error() instead of ruleset_error()

Abrir Fecha: 2022-04-14 16:03 Última actualización: 2022-05-29 07:38

Informador:
Propietario:
(Ninguno)
Tipo:
Estado:
Open
Componente:
Hito:
Prioridad:
5 - Medium
Gravedad:
5 - Medium
Resolución:
Ninguno
Fichero:
Ninguno

Details

effect_list_sanity_cb() reports some errors with log_error() instead of ruleset_error(). That's likely a bug.

Ticket History (3/3 Histories)

2022-04-14 16:03 Updated by: cazfi
  • New Ticket "effect_list_sanity_cb() uses log_error() instead of ruleset_error()" created
2022-05-29 07:26 Updated by: cazfi
  • Hito Update from (Ninguno) to 3.1.0
Comentario

rssanity.c does the same on number of places outside effect_list_sanity_cb()

As the ruleset_error() currently stands, there's not much difference between ruleset_error(LOG_ERROR ...) and log_error() -> this is probably not worth fixing in S3_0.

The main difference between those functions is that ruleset_error() has a buffer of just 1024 bytes, and do_log() that log_error() uses buffer size is MAX_LEN_LOG_LINE (5120), so changing those calls to ruleset_error() would actually risk truncating them. Will open a new ticket about increasing ruleset_error() buffer size.

2022-05-29 07:38 Updated by: cazfi
Comentario

Reply To cazfi

Will open a new ticket about increasing ruleset_error() buffer size.

-> #44704, consider that one dependency of this.

Attachment File List

No attachments

Editar

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Entrar