For2.2.2-Refactoring: angband_sound_name replacement

• Informador: backwardseric
• Propietario: deskull
• Tipo: Support Request
• Estado: Cerrado
• Componente: (Ninguno)
• Hito: 変愚蛮怒3.0.0alphaリリース (cerrado)
• Prioridad: 3
• Gravedad: 3
• Resolución: Fixed
• Fichero: Ninguno

Details

The removal of angband_sound_name as a global in the For2.2.2-Refactoring branch looks like it will lead to repetition of code (i.e. the definition of angband_sound_name currently in main_win.c) for every front end that wants to support sound. Would it be possible to restore angband_sound_name as a global or introduce a replacement interface which would allow front ends to support sound without each having to repeat the list of standard sound names?

Ticket History (3/5 Histories)

2020-01-22 02:27 Updated by: backwardseric

• New Ticket "For2.2.2-Refactoring: angband_sound_name replacement" created

2020-01-23 01:01 Updated by: deskull

• Hito Update from (Ninguno) to 変愚蛮怒3.0.0正式リリース (cerrado)
• Propietario Update from (Ninguno) to deskull

2020-01-25 21:42 Updated by: deskull

Comentario

I see. Now 'angband_sound_name' is only in main-win.c and main-x11.c. Therefore how about unifying those and moving to util.c/h?

2020-07-08 02:22 Updated by: backwardseric

• Estado Update from Open to Cerrado

Comentario

Thanks for main/sound-definitions-table.h which satisfies the initial request. I've closed the ticket.

2021-01-02 09:53 Updated by: deskull

• Hito Update from 変愚蛮怒3.0.0正式リリース (cerrado) to 変愚蛮怒3.0.0alphaリリース (cerrado)
• Resolución Update from Ninguno to Fixed